-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update markdown link #2030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Hi @junczhu , given this is the ratify broken link, lets fix the broken link. The link should be "https://ratify.dev/docs/troubleshoot/security#build-attestations" |
There is a point for discussion here, that we cannot ensure all links are active in proposals. @akashsinghal ,@binbin, should we consider moving implemented proposals to /archive? |
Signed-off-by: Juncheng Zhu <[email protected]>
curious if the scan should just run on the new markdowns in the PR. If we move the implemented proposals to /archive and ignore them, I feel it's the same as ignoring existing docs though there are some proposals not implemented. I think the essential question is if we want to keep updating expired links in all docs. |
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Description
What this PR does / why we need it:
Update markdown link to the latest available URL
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes CI markdown link failure
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change