Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update markdown link #2030

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Jan 14, 2025

Description

What this PR does / why we need it:

Update markdown link to the latest available URL

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes CI markdown link failure

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • CI Test

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 5 files with indirect coverage changes

@junczhu junczhu marked this pull request as ready for review January 14, 2025 06:39
@susanshi
Copy link
Collaborator

Hi @junczhu , given this is the ratify broken link, lets fix the broken link. The link should be "https://ratify.dev/docs/troubleshoot/security#build-attestations"

@susanshi
Copy link
Collaborator

There is a point for discussion here, that we cannot ensure all links are active in proposals. @akashsinghal ,@binbin, should we consider moving implemented proposals to /archive?

Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu junczhu changed the title chore: update markdown link check rule chore: update markdown link Jan 15, 2025
@binbin-li
Copy link
Collaborator

There is a point for discussion here, that we cannot ensure all links are active in proposals. @akashsinghal ,@binbin, should we consider moving implemented proposals to /archive?

curious if the scan should just run on the new markdowns in the PR. If we move the implemented proposals to /archive and ignore them, I feel it's the same as ignoring existing docs though there are some proposals not implemented. I think the essential question is if we want to keep updating expired links in all docs.

@susanshi susanshi enabled auto-merge (squash) January 15, 2025 22:20
@susanshi susanshi merged commit 37b65e2 into ratify-project:dev Jan 15, 2025
18 checks passed
@junczhu junczhu deleted the fix-mdl-ink branch January 15, 2025 23:42
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Jan 20, 2025
junczhu added a commit to junczhu/ratify that referenced this pull request Jan 21, 2025
binbin-li pushed a commit that referenced this pull request Jan 21, 2025
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants