Stage 1 public reference #2567
Open
Stage 1 public reference #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
reviewed
Mar 21, 2025
| @@ -111,7 +111,7 @@ impl<T: FieldElement> WitgenCallbackContext<T> { | |||
| current_witness: &[(String, Vec<T>)], | |||
| challenges: BTreeMap<u64, T>, | |||
| stage: u8, | |||
| ) -> Vec<(String, Vec<T>)> { | |||
| ) -> (Witness<T>, Publics<T>) { | |||
There was a problem hiding this comment.
Maybe not a topic of this PR, but I think this would need to receive the stage-0 publics as input as well, no? For example, we could have a constraint stage1_public = stage0_public;, or write a stage-0 public to the bus, or something like that.
Perhaps it makes sense to do that as part of this PR too if you implement this suggestion. Basically, we'd always group the trace and the publics-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2556. Pass stage 1 publics to the backend but not using them yet (TODO for future PR).