Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public examples #2572

Draft
wants to merge 3 commits into
base: stage-2-public-reference
Choose a base branch
from

Conversation

qwang98
Copy link
Collaborator

@qwang98 qwang98 commented Mar 21, 2025

Depends on #2567.

Did a blanket search of public declarations and added public references in all such cases. This will be required once public reference values instead of witness is solely used for proving.

To make all such updated public examples work, also make the following changes:

  1. Updated mock backend to use public reference values (this is technically the first backend that's edited to use public reference witgen).
  2. Updated pipeline functions for soundness tests (set_witness --> set_witness_and_publics).

@qwang98 qwang98 changed the base branch from main to stage-2-public-reference March 21, 2025 05:09
@Schaeff
Copy link
Collaborator

Schaeff commented Mar 21, 2025

Out of curiosity: do I understand correctly that we still have a RHS on public declarations, but it is not enforced in the circuit? Is it used for witgen? Can it be omitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants