fix(notifications): add name to filter

pkg/ai/types_ai.go

@@ -197,6 +197,8 @@ func UnmarshalAiNotificationsErrorInterface(b []byte) (*AiNotificationsErrorInte
 type AiNotificationsDestinationFilter struct {
 	// id
 	ID string `json:"id,omitempty"`
+	// Name
+	Name string `json:"name,omitempty"`
 }
 
 // SecureValue - The `SecureValue` scalar represents a secure value, ie a password, an API key, etc.

pkg/notifications/destinations_test.go

@@ -20,6 +20,7 @@ var (
 	user            = "test-user"
 	accountId       = 1
 	id              = "7463c367-6d61-416b-9aac-47f4a285fe5a"
+	name            = "test-notification-destination-1"
 
 	testCreateDestinationResponseJSON = `{
 	 "aiNotificationsCreateDestination": {
@@ -222,6 +223,60 @@ func TestGetDestinations(t *testing.T) {
 	assert.Equal(t, expected, actual)
 }
 
+func TestGetDestinationsByName(t *testing.T) {
+	t.Parallel()
+	respJSON := fmt.Sprintf(`{ "data":%s }`, testGetDestinationResponseJSON)
+	notifications := newMockResponse(t, respJSON, http.StatusOK)
+
+	auth := ai.AiNotificationsAuth{
+		AuthType: "BASIC",
+		User:     user,
+	}
+	auth.ImplementsAiNotificationsAuth()
+
+	expected := &AiNotificationsDestinationsResponse{
+		Entities: []AiNotificationsDestination{
+			{
+				AccountID:           accountId,
+				Active:              true,
+				Auth:                auth,
+				CreatedAt:           timestamp,
+				ID:                  id,
+				IsUserAuthenticated: false,
+				LastSent:            timestamp,
+				Name:                "test-notification-destination-1",
+				Properties: []AiNotificationsProperty{
+					{
+						DisplayValue: "",
+						Key:          "email",
+						Label:        "",
+						Value:        "[email protected]",
+					},
+				},
+				Status:    AiNotificationsDestinationStatusTypes.DEFAULT,
+				Type:      AiNotificationsDestinationTypeTypes.EMAIL,
+				UpdatedAt: timestamp,
+				UpdatedBy: 1547846,
+			},
+		},
+		Errors:     []AiNotificationsResponseError{},
+		Error:      AiNotificationsResponseError{},
+		NextCursor: "",
+		TotalCount: 1,
+	}
+
+	filters := ai.AiNotificationsDestinationFilter{
+		Name: name,
+	}
+	sorter := AiNotificationsDestinationSorter{}
+
+	actual, err := notifications.GetDestinations(accountId, "", filters, sorter)
+
+	assert.NoError(t, err)
+	assert.NotNil(t, actual)
+	assert.Equal(t, expected, actual)
+}
+
 func TestDeleteDestination(t *testing.T) {
 	t.Parallel()
 	respJSON := fmt.Sprintf(`{ "data":%s }`, testDeleteDestinationResponseJSON)

pkg/notifications/notifications_integration_test.go

@@ -15,7 +15,7 @@ import (
 	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 )
 
-func TestNotificationMutationDestination(t *testing.T) {
+func TestNotificationMutationDestinationById(t *testing.T) {
 	t.Parallel()
 
 	n := newIntegrationTestClient(t)
@@ -53,7 +53,7 @@ func TestNotificationMutationDestination(t *testing.T) {
 	require.NotEmpty(t, createResult.Destination.Auth)
 	require.Equal(t, ai.AiNotificationsAuthType("TOKEN"), createResult.Destination.Auth.AuthType)
 
-	// Test: Get Destination
+	// Test: Get Destination by id
 	filters := ai.AiNotificationsDestinationFilter{
 		ID: createResult.Destination.ID,
 	}
@@ -93,6 +93,84 @@ func TestNotificationMutationDestination(t *testing.T) {
 	require.NotNil(t, deleteResult)
 }
 
+func TestNotificationMutationDestinationByName(t *testing.T) {
+	t.Parallel()
+
+	n := newIntegrationTestClient(t)
+
+	accountID, err := mock.GetTestAccountID()
+	if err != nil {
+		t.Skipf("%s", err)
+	}
+
+	// Create a destination to work with in this test
+	testIntegrationDestinationNameRandStr := mock.RandSeq(5)
+	destination := AiNotificationsDestinationInput{}
+	destination.Type = AiNotificationsDestinationTypeTypes.WEBHOOK
+	destination.Properties = []AiNotificationsPropertyInput{
+		{
+			Key:          "url",
+			Value:        "https://webhook.site/94193c01-4a81-4782-8f1b-554d5230395b",
+			Label:        "",
+			DisplayValue: "",
+		},
+	}
+	destination.Auth = &AiNotificationsCredentialsInput{
+		Type: AiNotificationsAuthTypeTypes.TOKEN,
+		Token: AiNotificationsTokenAuthInput{
+			Token:  "Token",
+			Prefix: "Bearer",
+		},
+	}
+	destination.Name = fmt.Sprintf("test-notifications-destination-%s", testIntegrationDestinationNameRandStr)
+
+	// Test: Create
+	createResult, err := n.AiNotificationsCreateDestination(accountID, destination)
+	require.NoError(t, err)
+	require.NotNil(t, createResult)
+	require.NotEmpty(t, createResult.Destination.Auth)
+	require.Equal(t, ai.AiNotificationsAuthType("TOKEN"), createResult.Destination.Auth.AuthType)
+
+	// Test: Get Destination by name
+	filtersByName := ai.AiNotificationsDestinationFilter{
+		Name: createResult.Destination.Name,
+	}
+	sorter := AiNotificationsDestinationSorter{}
+	getDestinationByNameResult, err := n.GetDestinations(accountID, "", filtersByName, sorter)
+	require.NoError(t, err)
+	require.NotNil(t, getDestinationByNameResult)
+	assert.Equal(t, 1, getDestinationByNameResult.TotalCount)
+
+	// Test: Update Destination
+	updateDestination := AiNotificationsDestinationUpdate{}
+	updateDestination.Active = false
+	updateDestination.Properties = []AiNotificationsPropertyInput{
+		{
+			Key:          "url",
+			Value:        "https://webhook.site/94193c01-4a81-4782-8f1b-554d5230395b",
+			Label:        "",
+			DisplayValue: "",
+		},
+	}
+	updateDestination.Auth = &AiNotificationsCredentialsInput{
+		Type: AiNotificationsAuthTypeTypes.TOKEN,
+		Token: AiNotificationsTokenAuthInput{
+			Token:  "TokenUpdate",
+			Prefix: "BearerUpdate",
+		},
+	}
+	updateDestination.Name = fmt.Sprintf("test-notifications-update-destination-%s", testIntegrationDestinationNameRandStr)
+
+	updateDestinationResult, err := n.AiNotificationsUpdateDestination(accountID, updateDestination, createResult.Destination.ID)
+	require.NoError(t, err)
+	require.NotNil(t, updateDestinationResult)
+
+	// Test: Delete
+	deleteResult, err := n.AiNotificationsDeleteDestination(accountID, createResult.Destination.ID)
+	require.NoError(t, err)
+	require.NotNil(t, deleteResult)
+}
+
 func TestNotificationMutationChannel(t *testing.T) {
 	t.Parallel()