Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): add name to filter #1014

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

lzaga-newrelic
Copy link
Contributor

Add to AiNotificationsDestinationFilter the Name attribute.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #1014 (830db62) into main (4c18484) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   41.62%   41.62%           
=======================================
  Files          79       79           
  Lines        4956     4956           
=======================================
  Hits         2063     2063           
  Misses       2745     2745           
  Partials      148      148           
Flag Coverage Δ
unit 41.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pranav-new-relic
Copy link
Member

Looks good to me 👍

@pranav-new-relic pranav-new-relic merged commit 49d4025 into newrelic:main Jun 14, 2023
@lzaga-newrelic lzaga-newrelic deleted the add-name-to-filter branch June 14, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants