refactor(js): assign LogtoError code to message #133
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor(js): assign LogtoError code to message too
Problem:
is as same as
because
toThrowError
can only check the properties (e.g.message
) defined inError
,and cannot check the properties (e.g.
code
) defined in classesextends
fromError
.My solution is to assign the property
LogtoError.code
to its parent class propertyError.message
so that
toThrowError
can assert the content ofLogtoError.code
.Linear Issue Reference
Related #127 #131 LOG-1355 LOG1356
Testing
Pass all existing unit tests.
@logto-io/eng