Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js): add LogtoErrorCode.idToken.invalidToken and jest-matcher-specific-error #131

Merged
merged 5 commits into from
Jan 24, 2022
Merged

chore(js): add LogtoErrorCode.idToken.invalidToken and jest-matcher-specific-error #131

merged 5 commits into from
Jan 24, 2022

Conversation

IceHe
Copy link
Contributor

@IceHe IceHe commented Jan 21, 2022 •
edited
Loading

Summary

  • Add LogtoErrorCode.idToken.invalidToken
    • Make decodeIdToken throw LogtoErrorCode.idToken.invalidToken when needed
  • Simplify LogtoErrorCode.idToken.verification.invalidIat to LogtoErrorCode.idToken.invalidIat
  • Add development dependency jest-matcher-specific-error for matching specific error

Linear Issue Reference

LOG-1382
LOG-1355

Testing

Pass all existing tests.

@logto-io/eng

@IceHe IceHe force-pushed the icehe-log-1382 branch 2 times, most recently from 46c8734 to a8f6185 Compare January 21, 2022 06:34
@IceHe IceHe changed the title Icehe log 1382 chore(js): add LogtoErrorCode.idToken.invalidToken Jan 21, 2022
@IceHe IceHe added the chore Hmm... label Jan 21, 2022
@IceHe IceHe changed the title chore(js): add LogtoErrorCode.idToken.invalidToken chore(js): add LogtoErrorCode.idToken.decode.invalidToken Jan 21, 2022
@IceHe IceHe marked this pull request as ready for review January 21, 2022 07:43
@IceHe IceHe requested a review from simeng-li January 21, 2022 08:58
@IceHe IceHe mentioned this pull request Jan 21, 2022
Closed
@IceHe IceHe changed the title chore(js): add LogtoErrorCode.idToken.decode.invalidToken chore(js): add LogtoErrorCode.idToken.invalidToken Jan 21, 2022
@IceHe IceHe changed the title chore(js): add LogtoErrorCode.idToken.invalidToken chore(js): add LogtoErrorCode.idToken.invalidToken and jest-matcher-specific-error Jan 21, 2022
@IceHe
Copy link
Contributor Author

IceHe commented Jan 21, 2022

Added development dependency jest-matcher-specific-error for matching specific error

wangsijie
wangsijie approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IceHe IceHe merged commit 4b64aeb into master Jan 24, 2022
@IceHe IceHe deleted the icehe-log-1382 branch January 24, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie approved these changes

@simeng-li simeng-li simeng-li approved these changes

Assignees
No one assigned
Labels
chore Hmm...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceHe @wangsijie @simeng-li