[Merged by Bors] - chore: remove unnecessary @[eqns] attributes #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
|
bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Mar 25, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
These attributes are unused in Mathlib. Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (`hasFiniteIntegral_def`, `integrable_def`, `memℒp_def`, and `integrableOn_def`) to be deleted. We are currently experiencing problems with the `@[eqns]` attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib. Co-authored-by: Scott Morrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes are unused in Mathlib.
Many of them were workarounds for the now-resolved leanprover/lean4#2243; this also allows the lemmas themselves (
hasFiniteIntegral_def,integrable_def,memℒp_def, andintegrableOn_def) to be deleted.We are currently experiencing problems with the
@[eqns]attribute on the Lean nightlies. I'm uncertain yet what the outcome is going to be there, but it seems prudent to reduce our unnecessary exposure to a language feature added in Mathlib.