Testing r.pkg.template modifications for faster testing #1329
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,6 @@ arm_ref_comp_observer <- function(session, | |
| iv$add_validator(iv1) | ||
| iv$add_validator(iv2) | ||
|
|
||
| output[[output_id]] <- renderUI({ | ||
| if (isTRUE(on_off())) { | ||
| df <- if (is.reactive(data)) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,7 +48,7 @@ template_events_by_grade <- function(dataname, | |
| checkmate::assert_scalar(prune_diff) | ||
|
|
||
| y <- list() | ||
| message("Random code modified") | ||
| data_list <- list() | ||
|
|
||
| data_list <- add_expr( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| message("Random modification") | ||
|
|
||
| app_driver_tm_t_events_patyear <- function() { | ||
| data <- teal.data::teal_data() | ||
| data <- within(data, { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a suggestion to block accidental merge with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think you can just use the feature branch here so any updates on the branch will be reflected by simply triggering the workflow here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a comment. The problem with the feature branch was that it didn't like having multiple @ (the branch name is
580_module_tests@main):338e058(#1329) and it didn't trigger the tests. After that I use the commits to be able to run the checks manually.