Testing r.pkg.template modifications for faster testing #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vedhav
reviewed
Feb 4, 2025
| @@ -21,7 +21,7 @@ jobs: | |||
| uses: insightsengineering/r.pkg.template/.github/workflows/audit.yaml@main | |||
| r-cmd: | |||
| name: R CMD Check 🧬 | |||
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main | |||
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@38b63dee0b54d8b50dd360b1b40258feb081ed54 | |||
There was a problem hiding this comment.
Suggested change
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@38b63dee0b54d8b50dd360b1b40258feb081ed54 | |
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main |
Just adding a suggestion to block accidental merge with this.
There was a problem hiding this comment.
But I think you can just use the feature branch here so any updates on the branch will be reflected by simply triggering the workflow here.
There was a problem hiding this comment.
Thanks for opening a comment. The problem with the feature branch was that it didn't like having multiple @ (the branch name is 580_module_tests@main): 338e058 (#1329) and it didn't trigger the tests. After that I use the commits to be able to run the checks manually.
vedhav
reviewed
Feb 4, 2025
| @@ -44,7 +44,7 @@ jobs: | |||
| deps-installation-method: setup-r-dependencies | |||
| r-cmd-non-cran: | |||
| name: R CMD Check (non-CRAN) 🧬 | |||
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main | |||
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@38b63dee0b54d8b50dd360b1b40258feb081ed54 | |||
There was a problem hiding this comment.
Suggested change
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@38b63dee0b54d8b50dd360b1b40258feb081ed54 | |
| uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main |
Just adding a suggestion to block accidental merge with this.
|
Testing is happening on #1332 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Do not merge
Part of : https://github.com/insightsengineering/coredev-tasks/issues/580
This PR has modifications on:
In its current form all the tests should be run at take 2h.
Remove the modification on the helper file and it should only run tests specific to the module and test file modified.