Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fingerprint: digitalocean fingerprint test requires metadata header #12028

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 8, 2022

Fixes the unit tests on main, which for some reason didn't run for #12015

This PR should fix the broken test, but that being said @kevinschoonover I'm not sure I understand where the test requirement for that header is coming from. I don't see anything about that in the DO docs: https://docs.digitalocean.com/reference/api/metadata-api/

Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross merged commit 79e8d39 into main Feb 8, 2022
@tgross tgross deleted the do_fingerprint_metadata_header branch February 8, 2022 21:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants