Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fingerprint: remove metadata from digitalocean #12032

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

kevinschoonover
Copy link
Contributor

@kevinschoonover kevinschoonover commented Feb 9, 2022

follow up to #12028.

Feel free to close this as noise as I'm not sure if this PR is necessary, but wanted to try to address the comments on #12028 since metadata was a remanent of me copying the GCE fingerprinter and is not necessary / used.

ran the tests locally:

 > pwd
./nomad/client/fingerprint
> go test
PASS
ok  	github.com/hashicorp/nomad/client/fingerprint	0.875s

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and thanks for following up.

I'm not sure why CircleCI isn't running for your PRs. It does for other non-HashiCorp contributors (ex #12021) and as far as I can tell there's nothing in the workflows that should be excluding you, so that's weird. But that's on us to figure out 😀

@tgross tgross merged commit 6633f8d into hashicorp:main Feb 9, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants