Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nexus-611] feat: added permission boundary support #27

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions modules/sso/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,39 @@ resource "aws_ssoadmin_permission_set" "this" {
session_duration = try(each.value.session_duration, "PT12H")
}

# attaches permission boundaries
resource "aws_ssoadmin_permissions_boundary_attachment" "this" {
for_each = {
for p in concat(var.managed_permission_sets, var.inline_permission_sets) :
p.name => p if p.permissions_boundary != null
}

instance_arn = local.sso_instance_arn
permission_set_arn = aws_ssoadmin_permission_set.this[each.key].arn

# the two dynamic blocks are enforced to be mutually exclusive
# sets customer_managed policy if not null
dynamic "permissions_boundary" {
for_each = each.value.permissions_boundary.customer_managed_policy_reference != null ? [each.value.permissions_boundary.customer_managed_policy_reference] : []
content {
dynamic "customer_managed_policy_reference" {
for_each = [permissions_boundary.value]
content {
name = customer_managed_policy_reference.value.name
path = customer_managed_policy_reference.value.path
}
}
}
}

# sets managed_policy_arn if not null
dynamic "permissions_boundary" {
for_each = each.value.permissions_boundary.managed_policy_arn != null ? [each.value.permissions_boundary.managed_policy_arn] : []
content {
managed_policy_arn = permissions_boundary.value
}
}
}

# attaches an AWS Managed IAM Policy to a permission set
resource "aws_ssoadmin_managed_policy_attachment" "this" {
Expand Down
48 changes: 46 additions & 2 deletions modules/sso/variables.tf
Original file line number Diff line number Diff line change
@@ -1,11 +1,55 @@
variable "managed_permission_sets" {
type = list(any)
type = list(object({
name = string
description = string
attached_policies = list(string)
session_duration = optional(string, "PT12H")
permissions_boundary = optional(object({
managed_policy_arn = optional(string)
customer_managed_policy_reference = optional(object({
name = string
path = optional(string, "/")
}))
}))
}))
description = "List of the required Permission Sets that contain AWS Managed Policies"

validation {
condition = alltrue([
for ps in var.managed_permission_sets :
ps.permissions_boundary == null ||
(ps.permissions_boundary.managed_policy_arn != null) !=
(ps.permissions_boundary.customer_managed_policy_reference != null)
])
error_message = "When permissions_boundary is set, exactly one of managed_policy_arn or customer_managed_policy_reference must be provided."
}
}

variable "inline_permission_sets" {
type = list(any)
type = list(object({
name = string
description = string
inline_policy = string
session_duration = optional(string)
Copy link
Contributor

@schattingh schattingh Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
session_duration = optional(string)
session_duration = optional(string, "PT12H")

Declaring this argument without a default is overriding the try statement in the resource block, resulting in all session durations being changed back to the default of PT1H1

permissions_boundary = optional(object({
managed_policy_arn = optional(string)
customer_managed_policy_reference = optional(object({
name = string
path = optional(string, "/")
}))
}))
}))
description = "List of the required Permission Sets that are comprised of inline IAM Policies"

validation {
condition = alltrue([
for ps in var.inline_permission_sets :
ps.permissions_boundary == null ||
(ps.permissions_boundary.managed_policy_arn != null) !=
(ps.permissions_boundary.customer_managed_policy_reference != null)
])
error_message = "When permissions_boundary is set, exactly one of managed_policy_arn or customer_managed_policy_reference must be provided."
}
}

variable "sso_groups" {
Expand Down