[Nexus-611] feat: added permission boundary support #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schattingh
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Hi @DavideNale , I am receiving an error when testing this PR:
│ Error: Invalid variable validation condition
│
│ on .terraform/modules/org_sso/modules/sso/variables.tf line 18, in variable "managed_permission_sets":
│ 18: condition = alltrue([
│ 19: for ps in var.inline_permission_sets :
│ 20: ps.permissions_boundary == null ||
│ 21: (ps.permissions_boundary.managed_policy_arn != null) !=
│ 22: (ps.permissions_boundary.customer_managed_policy_reference != null)
│ 23: ])
│
│ The condition for variable "managed_permission_sets" must refer to var.managed_permission_sets in order to test incoming values.
modules/sso/variables.tf
Outdated
| name = string | ||
| description = string | ||
| inline_policy = string | ||
| session_duration = optional(string) |
There was a problem hiding this comment.
Suggested change
| session_duration = optional(string) | |
| session_duration = optional(string, "PT12H") |
Declaring this argument without a default is overriding the try statement in the resource block, resulting in all session durations being changed back to the default of PT1H1
Co-authored-by: Carl Hattingh <[email protected]>
schattingh
requested changes
Feb 26, 2025
There was a problem hiding this comment.
I'm till getting an error:
│ Error: Attempt to get attribute from null value
│
│ on .terraform/modules/org_sso/modules/sso/variables.tf line 49, in variable "inline_permission_sets":
│ 49: (ps.permissions_boundary.customer_managed_policy_reference != null)
│ ├────────────────
│ │ ps.permissions_boundary is null
│
│ This value is null, so it does not have any attributes.
How are you testing this?
DavideNale
force-pushed
the
nexus-611
branch
from
65c640f to
8d49b67
Compare
|
@schattingh I'm testing it with nexus-config/platform-identity but I was doing a mistake while doing so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tasks
Does this PR relate to other tasks?
No
Depends on
Are there any other PRs that need to be merged first?
No
What
What changes have been made within this PR?
Added the support for permission boundary for
managed_permission_setsandinline_permission_sets.Why
Why are we submitting this PR? What is the context, engineering and business goals being satisfied by this PR?
Added the support for permission boundary to allow the attachment of restriction policies to allow the AU platform team to work on EU resources without infringing GDPR.