Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop support for py 3.8 and update to poetry 2 in our CI #249

Merged
merged 36 commits into from
Feb 20, 2025

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Jan 16, 2025

This PR removes support for py3.8 (which is end of life) and updates our CI to use poetry 2, the newest version of poetry. The CI update allows us to lock our dependencies across all versions of python.

TODO:

[tool.poetry.requires-plugins]
poetry-conda = ">=0.1.4"
poetry-plugin-export = ">=1.9"
poetry-plugin-shell = ">=1.0.1"

@aryarm

This comment was marked as resolved.

@aryarm aryarm marked this pull request as ready for review February 4, 2025 16:41
@aryarm
Copy link
Member Author

aryarm commented Feb 4, 2025

This PR is finally ready! It resolves the problem that we first encountered in #202 (comment) where we couldn't lock our dependencies for py3.9+. I reported this issue in cjolowicz/nox-poetry#1116 and identified a solution in this discussion thread. Once this gets merged, all of our dependencies will finally be locked across all versions of python! 🎉

In this PR, I also identitied a new pattern for our locked versions going forward. From now on, every version of every dependency should be locked to three different versions in our lock file:

  1. the minimum version that is supported by our tool in the [project.dependencies] section
  2. the minimum version that is supported by the minimum version of Python that is not end-of-life (ie the version being used in our development environment)
  3. the newest version

@aryarm aryarm changed the title ci: update to poetry 2 doc: drop support for py 3.8 and update to poetry 2 in our CI Feb 4, 2025
@aryarm aryarm changed the title doc: drop support for py 3.8 and update to poetry 2 in our CI docs: drop support for py 3.8 and update to poetry 2 in our CI Feb 4, 2025
@aryarm aryarm changed the title docs: drop support for py 3.8 and update to poetry 2 in our CI docs: drop support for py 3.8 and update to poetry 2 + add py3.13 in our CI Feb 5, 2025
pip can't retrieve the wheel for some reason
@aryarm aryarm changed the title docs: drop support for py 3.8 and update to poetry 2 + add py3.13 in our CI docs: drop support for py 3.8 and update to poetry 2 in our CI Feb 5, 2025
@aryarm aryarm requested a review from aarushi03 February 12, 2025 19:04
Co-authored-by: Arya Massarat <[email protected]>
@aryarm aryarm merged commit 6bdc596 into master Feb 20, 2025
13 checks passed
@aryarm aryarm deleted the ci/poetry2 branch February 20, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants