Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove --region-file option and update to poetry 2 in our CI #11

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Feb 20, 2025

This PR proposes merging the --region and --region-file options of the complexity command to make the behavior consistent with the examples in the docs for the complexity command -- specifically, this example:

panct complexity \
  --region regions.bed --out test.tab \
  --metrics sequniq-normwalk,sequniq-normnode \
  hprc-v1.1-mc-grch38.gbz

(We automatically detect whether the input is a single region or a path to a BED file of regions.)

This PR also migrates our CI to poetry 2 like in gymrek-lab/TRTools#249 and it adds some directions for users who might need to install gbz-base. Finally, it bumps our minimum python version to 3.10 so that we can use the newest type-hinting features. But if we would prefer to keep support for 3.9 (which is technically still not end-of-life at least until the end of the 2025), I can easily revert the changes.

TODO:

  • add tests for BED file input. I don't think there are any as of yet?
    • fix xfail in the new tests

@aryarm aryarm requested a review from aarushi03 February 20, 2025 00:33
@aryarm aryarm changed the title fix: remove --region-file option fix: remove --region-file option and update to poetry 2 in our CI Feb 20, 2025
@aryarm
Copy link
Member Author

aryarm commented Feb 26, 2025

Update: I just finished adding tests and some other docs. This is now ready for you to take a look, @aarushi03! 🎉

@aryarm aryarm changed the title fix: remove --region-file option and update to poetry 2 in our CI fix!: remove --region-file option and update to poetry 2 in our CI Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant