-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove --region-file option and update to poetry 2 in our CI #11
Open
aryarm
wants to merge
16
commits into
main
Choose a base branch
from
feat/regions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: I just finished adding tests and some other docs. This is now ready for you to take a look, @aarushi03! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes merging the --region and --region-file options of the complexity command to make the behavior consistent with the examples in the docs for the complexity command -- specifically, this example:
(We automatically detect whether the input is a single region or a path to a BED file of regions.)
This PR also migrates our CI to poetry 2 like in gymrek-lab/TRTools#249 and it adds some directions for users who might need to install gbz-base. Finally, it bumps our minimum python version to 3.10 so that we can use the newest type-hinting features. But if we would prefer to keep support for 3.9 (which is technically still not end-of-life at least until the end of the 2025), I can easily revert the changes.
TODO: