Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual controls prompt #322

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Visual controls prompt #322

merged 2 commits into from
Jan 31, 2019

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Jan 30, 2019 •
edited
Loading

This change proposes a visual counterpart to the controls prompt suggested in #319 .

  • The timing and dismissal logic is the same as the ARIA prompt
  • An animated SVG is bundled to offer a reasonable default experience
  • Default prompt can be overridden by distributing "light tree" content to the controls-prompt slot

Default visual prompt

controlsprompt

Customized visual prompt

<model-viewer src="something.gltf" controls>
  <!-- NOTE: Any custom content (not just images) can be used in place
       of the default prompt: -->
  <img src="something.gif" slot="controls-prompt">
</model-viewer>

controlspromptcustom

fixes #317

@jsantell jsantell mentioned this pull request Jan 30, 2019
Merged
@cdata cdata changed the base branch from master to announce-controls January 31, 2019 06:13
@cdata cdata force-pushed the visual-control-prompt branch from c13c646 to ba1c05a Compare January 31, 2019 16:14
@cdata cdata changed the title (WIP) Visual controls prompt Visual controls prompt Jan 31, 2019
smalls
smalls approved these changes Jan 31, 2019
View reviewed changes
examples/background-image.html Outdated
@@ -58,6 +58,7 @@ <h2>With Equirectangular background-image</h2>
background-image="assets/whipple_creek_regional_park_04_1k.jpg"
alt="A 3D model of a damaged helmet with a forest in the background"
src="assets/DamagedHelmet/DamagedHelmet.gltf">
<img src="https://upload.wikimedia.org/wikipedia/commons/c/c4/24-cell-orig.gif" slot="controls-prompt" width="200">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will revert...

@cdata cdata merged commit f567b87 into announce-controls Jan 31, 2019
@cdata cdata deleted the visual-control-prompt branch January 31, 2019 17:59
@cdata cdata mentioned this pull request Jan 31, 2019
Merged
@cdata cdata mentioned this pull request Mar 19, 2019
Closed
@cdata cdata mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalls smalls smalls approved these changes

@jsantell jsantell Awaiting requested review from jsantell

@yuinchien yuinchien Awaiting requested review from yuinchien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdata @smalls