Announce camera orientation #325
Merged
+105
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
announce-camera-orientation
branch
2 times, most recently
from
d76cf9c to
fe57deb
Compare
jsantell
approved these changes
Jan 31, 2019
|
|
||
| import {$ariaLabel, $needsRender, $onModelLoad, $onResize, $scene, $tick} from '../model-viewer-base.js'; | ||
| import {FRAMED_HEIGHT} from '../three-components/ModelScene.js'; | ||
| import {SmoothControls} from '../three-components/SmoothControls.js'; | ||
|
|
||
| const HALF_PI = Math.PI / 2.0; | ||
| const THIRD_PI = Math.PI / 3.0; | ||
| const QUARTER_PI = HALF_PI / 2.0; |
|
|
||
| const {theta: lastTheta, phi: lastPhi} = this[$lastSpherical]; | ||
| const {theta, phi} = | ||
| this[$controls].getCameraSpherical(this[$lastSpherical]); |
cdata
force-pushed
the
announce-camera-orientation
branch
from
fe57deb to
0de7672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is meant to complement a11y / interaction improvements brought by #319 and #322 .
Fixes #315