Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Translate Chapter 60 (Shared State) #1690

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

kantasv
Copy link
Collaborator

@kantasv kantasv commented Jan 13, 2024

Hi, ja translation team (#652 ). Here's an MR for the chapter "Shared States." Could you review the translations? any feedback would be appreciated. Thank you 😄

cc: @keiichiw , @chikoski , @HidenoriKobayashi , @ternbusty
(Retrieved translaftion draft #1636 Chapter 60 draft, after recent ja.po file refresh #1676 )

po/ja.po Outdated
Comment on lines 18443 to 18445
"スレッドにパニックを起こした`Mutex`がある場合、保護すべきデータが整合性の欠け"
"た状態にある可能性を伝えるため、`Mutex`は「ポイゾンされた」(\"poisoned\")状"
"態になります。ポイゾンされたMutexに対して `lock()` をコールすると、"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referred to JA Rustbook's translation, i.e., "poison" -> "ポイゾン" https://doc.rust-jp.rs/rust-nomicon-ja/poisoning.html

Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some readability suggestions. You may want to double check with reviewers before actually making changes though.

@kantasv
Copy link
Collaborator Author

kantasv commented Jan 17, 2024

Hi, @HidenoriKobayashi thanks for your feedback. I applied changes :)
If you're interested, could you be a codeowner of the ja.po file?

@HidenoriKobayashi
Copy link
Collaborator

Hi, @HidenoriKobayashi thanks for your feedback. I applied changes :) If you're interested, could you be a codeowner of the ja.po file?

Sure, if other folks are fine with that.

Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@keiichiw
Copy link
Collaborator

Hi, @HidenoriKobayashi thanks for your feedback. I applied changes :) If you're interested, could you be a codeowner of the ja.po file?

Sure, if other folks are fine with that.

I'm fine with adding Hidenori to the owner file. Feel free to create a PR

@kantasv
Copy link
Collaborator Author

kantasv commented Jan 18, 2024

Thanks @keiichiw -san for concrete feedback and suggestions with references, which helps a lot! I have delivered changes based on your comments. Could you reveiw it once again? Thank you!

Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the change

@keiichiw keiichiw merged commit 9b8e4b3 into google:main Jan 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants