-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja: Translate Chapter 60 (Shared State) #1690
ja: Translate Chapter 60 (Shared State) #1690
Conversation
po/ja.po
Outdated
"スレッドにパニックを起こした`Mutex`がある場合、保護すべきデータが整合性の欠け" | ||
"た状態にある可能性を伝えるため、`Mutex`は「ポイゾンされた」(\"poisoned\")状" | ||
"態になります。ポイゾンされたMutexに対して `lock()` をコールすると、" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referred to JA Rustbook's translation, i.e., "poison" -> "ポイゾン" https://doc.rust-jp.rs/rust-nomicon-ja/poisoning.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some readability suggestions. You may want to double check with reviewers before actually making changes though.
Hi, @HidenoriKobayashi thanks for your feedback. I applied changes :) |
Sure, if other folks are fine with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm fine with adding Hidenori to the owner file. Feel free to create a PR |
Thanks @keiichiw -san for concrete feedback and suggestions with references, which helps a lot! I have delivered changes based on your comments. Could you reveiw it once again? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the change
Hi, ja translation team (#652 ). Here's an MR for the chapter "Shared States." Could you review the translations? any feedback would be appreciated. Thank you 😄
cc: @keiichiw , @chikoski , @HidenoriKobayashi , @ternbusty
(Retrieved translaftion draft #1636 Chapter 60 draft, after recent
ja.po
file refresh #1676 )