Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use env_cfg.to_dict() to avoid double JSON serialization (#43) #53

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

vincentzhang
Copy link
Contributor

This PR fixes issue #43 by replacing
json.dump(env_cfg.to_json(), fp, indent=4)
with
json.dump(env_cfg.to_dict(), fp, indent=4)
following the original suggestion.

@kevinzakka
Copy link
Collaborator

Thanks @vincentzhang !

@vincentzhang
Copy link
Contributor Author

vincentzhang commented Feb 12, 2025

The failed tests seem to be related to the previous commit at 3c2583b
It seems to be a new MuJoCo feature introduced in google-deepmind/mujoco@cef5b31
which is not in the current MuJoCo release (3.2.7).

Scope of impact of this API change:
mujoco_playground/_src/dm_control_suite/reacher.py
and the unit test in
mujoco_playground/_src/dm_control_suite/dm_control_suite_test.py

@kevinzakka
Copy link
Collaborator

I'm waiting for the new MuJoCo release which should be out next week. We can merge this PR then?

@vincentzhang
Copy link
Contributor Author

Good to know. Yeah I think this PR is good to go

@copybara-service copybara-service bot merged commit 0b021c9 into google-deepmind:main Feb 14, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants