weights update - all pallets #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing needs re-do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use weights from hydra benchmark machine for all pallets the node uses.
Perform benchmarks of each pallet on hydra bench machine.
Benchmarks of some of the pallet cannot complete successfully with the parameters set in the runtime:
Democracy - fails with
MaxVotesReachederrorTips - fails with
ReasonTooBigerrorElection phragmen - fails with
Failed to submit candidacyBalances - fails because Existential deposit is 0.
And the following fails to compile with
runtime-benchmarksfeatures : collective, election_provider_multi_phase.Babe and grandpa generate different WeightInfo that the one in the pallet - so not sure what to do about that.
For those pallets mentioned above - it uses
SubstrateWeightsfor now.Related Issue
#203