Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Re-benchmark every pallet in runtime #203

Closed
jak-pan opened this issue Apr 9, 2021 · 4 comments
Closed

Bug: Re-benchmark every pallet in runtime #203

jak-pan opened this issue Apr 9, 2021 · 4 comments
Assignees

Comments

@jak-pan
Copy link
Contributor

jak-pan commented Apr 9, 2021

As noted by @apopiak here: #188 (comment) we should re-weight every pallet in our runtime (with our settings) and use that instead of default.

@apopiak
Copy link
Contributor

apopiak commented Apr 9, 2021

Just saw that Kusama also uses default weights in some places. So I guess you don't have to literally re-weight everything (that was just my gut reaction), but check all the pallets on whether they need to be weighted.

Re-weighting all of them is just the safe default. If you are confident that the benchmark will give the same result (because you use the same config on the same benchmarking hardware) you can skip it of course.

@jak-pan
Copy link
Contributor Author

jak-pan commented Apr 9, 2021

Just saw that Kusama also uses default weights in some places. So I guess you don't have to literally re-weight everything (that was just my gut reaction), but check all the pallets on whether they need to be weighted.

Re-weighting all of them is just the safe default. If you are confident that the benchmark will give the same result (because you use the same config on the same benchmarking hardware) you can skip it of course.

It's not that much work / time to do all of them on top of existing benchmarks so we might just add everything to be safe.

@jak-pan
Copy link
Contributor Author

jak-pan commented Apr 10, 2021

Also I've noticed that every transaction currently costs the same amount to execute. We should have a look at why this happens since exchange:buy should be more expensive than balance transfers. We should also check the multiplier of weigh to be in sync with current DOLLARS and later dynamic.

@jak-pan
Copy link
Contributor Author

jak-pan commented Apr 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants