This repository has been archived by the owner on Jun 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 377
corrected some grammatical errors #70
Open
Manyaverma
wants to merge
1
commit into
facebookarchive:master
Choose a base branch
from
Manyaverma:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ An iOS library providing developer tools for browsing objects in memory over tim | |
|
||
## About | ||
|
||
This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate together, and how they can be used in real app. | ||
This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate Together, and how they can be used in real app. | ||
|
||
It uses [FBAllocationTracker](https://github.com/facebook/FBAllocationTracker) to gather information about the objects. | ||
It supports [generations](https://github.com/facebook/FBAllocationTracker#generations) and [retain cycle detection](https://github.com/facebook/FBRetainCycleDetector). | ||
|
@@ -73,14 +73,14 @@ _memoryProfiler = [[FBMemoryProfiler alloc] initWithPlugins:@[[IncredibleCacheCl | |
[AwesomeLoggerPlugin new]] | ||
retainCycleDetectorConfiguration:someConfigurationWithCustomFilters]; | ||
[_memoryProfiler enable]; | ||
``` | ||
|
||
## Plugins | ||
|
||
##Plugins | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is removing the space after ## necessary? |
||
|
||
Plugins are objects that conform to [FBMemoryProfilerPluggable](FBMemoryProfiler/Options/FBMemoryProfilerPluggable.h) protocol. Example usage: [custom cache cleaners](Example/ExampleApp/CacheCleanerPlugin.h), [loggers that log data to server](Example/ExampleApp/RetainCycleLoggerPlugin.h). | ||
|
||
## Contributing | ||
See the [CONTRIBUTING](CONTRIBUTING.md) file for how to help out. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like this is a regression, i don't think the link will work anomore |
||
See the CONTRIBUTING](CONTRIBUTING.md) file for how to help out. | ||
|
||
## License | ||
See (LICENSE) | ||
See(LICENSE) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to capitalize the word