Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

corrected some grammatical errors #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Manyaverma
Copy link

No description provided.

@facebook-github-bot
Copy link

Hi MANYA-123! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@megCanicalKb
Copy link

Hi, thanks for contributing to the project.
I have some feedback on the change:

  • "Together" doesn't need to be capitalized
  • i am not sure why "## Plugins" turned into "##Plugins", does the space matter? If so then there are other that need to be updated
  • changing "[CONTRIBUTING]" to "CONTRIBUTING]" sounds like a regression

Let me know when you've fixed the changes :)

@@ -7,7 +7,7 @@ An iOS library providing developer tools for browsing objects in memory over tim

## About

This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate together, and how they can be used in real app.
This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate Together, and how they can be used in real app.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to capitalize the word


## Plugins

##Plugins

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is removing the space after ## necessary?


Plugins are objects that conform to [FBMemoryProfilerPluggable](FBMemoryProfiler/Options/FBMemoryProfilerPluggable.h) protocol. Example usage: [custom cache cleaners](Example/ExampleApp/CacheCleanerPlugin.h), [loggers that log data to server](Example/ExampleApp/RetainCycleLoggerPlugin.h).

## Contributing
See the [CONTRIBUTING](CONTRIBUTING.md) file for how to help out.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is a regression, i don't think the link will work anomore

Copy link

@megCanicalKb megCanicalKb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some feedback about the change:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants