-
Notifications
You must be signed in to change notification settings - Fork 377
corrected some grammatical errors #70
base: master
Are you sure you want to change the base?
Conversation
Hi MANYA-123! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Hi, thanks for contributing to the project.
Let me know when you've fixed the changes :) |
@@ -7,7 +7,7 @@ An iOS library providing developer tools for browsing objects in memory over tim | |||
|
|||
## About | |||
|
|||
This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate together, and how they can be used in real app. | |||
This library shows how `FBAllocationTracker` and `FBRetainCycleDetector` can cooperate Together, and how they can be used in real app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to capitalize the word
|
||
## Plugins | ||
|
||
##Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is removing the space after ## necessary?
|
||
Plugins are objects that conform to [FBMemoryProfilerPluggable](FBMemoryProfiler/Options/FBMemoryProfilerPluggable.h) protocol. Example usage: [custom cache cleaners](Example/ExampleApp/CacheCleanerPlugin.h), [loggers that log data to server](Example/ExampleApp/RetainCycleLoggerPlugin.h). | ||
|
||
## Contributing | ||
See the [CONTRIBUTING](CONTRIBUTING.md) file for how to help out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is a regression, i don't think the link will work anomore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some feedback about the change:
No description provided.