refactor: Renamed GolangRuntime to FunctionPipelineRuntime #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 66.70% 66.70%
=======================================
Files 39 39
Lines 3325 3325
=======================================
Hits 2218 2218
Misses 961 961
Partials 146 146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
requested changes
Nov 29, 2022
internal/runtime/runtime.go
Outdated
| @@ -66,8 +66,8 @@ func NewFunctionPipeline(id string, topics []string, transforms []interfaces.App | |||
| return pipeline | |||
| } | |||
|
|
|||
| // GolangRuntime represents the golang runtime environment | |||
| type GolangRuntime struct { | |||
| // AppServiceRuntime represents the golang runtime environment | |||
There was a problem hiding this comment.
Suggested change
| // AppServiceRuntime represents the golang runtime environment | |
| // AppServiceRuntime represents the runtime environment for App Services' Functions Pipelines |
There was a problem hiding this comment.
Would a better name be FunctionsPipelineRuntime or PipelineRuntime since that is what the runtime is about?
There was a problem hiding this comment.
I think FunctionsPipelinetRuntime would be more descriptive
marcpfuller
added a commit
to marcpfuller/app-functions-sdk-go
that referenced
this pull request
Nov 29, 2022
…ndry#1199 Signed-off-by: Marc-Philippe Fuller <[email protected]>
lenny-goodell
changed the title
lenny-goodell
changed the title
Signed-off-by: Marc-Philippe Fuller <[email protected]>
marcpfuller
added a commit
to marcpfuller/app-functions-sdk-go
that referenced
this pull request
Nov 30, 2022
…ndry#1199 Signed-off-by: Marc-Philippe Fuller <[email protected]>
marcpfuller
force-pushed
the
appServiceRuntime
branch
from
c13b314 to
c8c98ea
Compare
I have rebased and fixed all conflicts |
marcpfuller
force-pushed
the
appServiceRuntime
branch
from
c8c98ea to
9840e4e
Compare
rename Golangruntine to FunctionPipelineRuntime for better readability Closes edgexfoundry#1199 Signed-off-by: Marc-Philippe Fuller <[email protected]>
marcpfuller
force-pushed
the
appServiceRuntime
branch
from
9840e4e to
0ee5f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc-Philippe Fuller [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
make test
New Dependency Instructions (If applicable)
N/A