Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the GolangRuntime to FunctionPipelineRuntime #1199

Closed
marcpfuller opened this issue Oct 24, 2022 · 0 comments · Fixed by #1229
Closed

Change the GolangRuntime to FunctionPipelineRuntime #1199

marcpfuller opened this issue Oct 24, 2022 · 0 comments · Fixed by #1229
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Milestone
Minnesota

Comments

@marcpfuller
Copy link
Contributor

marcpfuller commented Oct 24, 2022 •
edited by lenny-goodell
Loading

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for app-functions-sdk-go

Description [REQUIRED]

A clear and concise description of the problem or missing capability...

The use of the name GolangRuntime isnt very meaningful variable/object name in my opinion from a maintainability/readability standpoint.

Describe the solution you'd like

If you have a solution in mind, please describe it.

I would suggest changing this to FunctionPipelineRuntime , or something similarly or more descriptive.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@marcpfuller marcpfuller added the question Further information is requested label Oct 24, 2022
@lenny-goodell lenny-goodell added tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds and removed question Further information is requested labels Oct 25, 2022
@lenny-goodell lenny-goodell added this to the Minnesota milestone Oct 25, 2022
@lenny-goodell lenny-goodell moved this from Ice Box to Minnesota Release Backlog in Application Services Nov 16, 2022
marcpfuller added a commit to marcpfuller/app-functions-sdk-go that referenced this issue Nov 29, 2022
@marcpfuller
fix: resolve comments made in PR edgexfoundry#1229 for issue edgexfou…
c13b314 
…ndry#1199

Signed-off-by: Marc-Philippe Fuller <[email protected]>
@lenny-goodell lenny-goodell moved this from Minnesota Release Backlog to In Progress in Application Services Nov 29, 2022
marcpfuller added a commit to marcpfuller/app-functions-sdk-go that referenced this issue Nov 30, 2022
@marcpfuller
fix: resolve comments made in PR edgexfoundry#1229 for issue edgexfou…
c8c98ea 
…ndry#1199

Signed-off-by: Marc-Philippe Fuller <[email protected]>
marcpfuller added a commit to marcpfuller/app-functions-sdk-go that referenced this issue Nov 30, 2022
@marcpfuller
refactor(sdk): rename golangruntime to FunctionPipelineRuntime
0ee5f87 
rename  Golangruntine to FunctionPipelineRuntime for better readability

Closes edgexfoundry#1199

Signed-off-by: Marc-Philippe Fuller <[email protected]>
Repository owner moved this from In Progress to Done in Application Services Nov 30, 2022
@lenny-goodell lenny-goodell linked a pull request Nov 30, 2022 that will close this issue
refactor: Renamed GolangRuntime to FunctionPipelineRuntime #1229
Merged
5 tasks
@lenny-goodell lenny-goodell changed the title Change the GolangRuntime to AppServiceRuntime Change the GolangRuntime to FunctionPipelineRuntime Nov 30, 2022
@lenny-goodell lenny-goodell moved this from Done to Previously Done in Application Services Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
No open projects
Application Services
Archived in project
Milestone
Minnesota
Development

Successfully merging a pull request may close this issue.

refactor: Renamed GolangRuntime to FunctionPipelineRuntime marcpfuller/app-functions-sdk-go
2 participants
@lenny-goodell @marcpfuller