Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct metric instance when reporting PipelineMessagesProcessed #1197

Conversation

lenny-goodell
Copy link
Member

fixes #1196

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run non-secure EdgeX stack with Device Virtual
Build and run app template locally with only PipelineMessagesProcessed enabled.
Run ASC with metrics-influxdb profile locally with DEBUG logging.

./app-service-configurable -p metrics-influxdb | grep "Transformed Metric"

Verify the PipelineMessagesProcessed is a simple counter metric rather than a timer metric

'PipelineMessagesProcessed,service=new-app-service,pipeline=default-pipeline counter-count=152 1666637357546351500\n'

New Dependency Instructions (If applicable)

jim-wang-intel
jim-wang-intel previously approved these changes Oct 24, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this pull request Oct 24, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this pull request Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1197 (19b2b0a) into main (b219f0d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files          39       39           
  Lines        3302     3302           
=======================================
  Hits         2203     2203           
  Misses        953      953           
  Partials      146      146           
Impacted Files Coverage Δ
internal/runtime/runtime.go 80.08% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit cec20cd into edgexfoundry:main Oct 25, 2022
@lenny-goodell lenny-goodell deleted the fix-PipelineMessagesProcessed-reported branch October 25, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipelineMessagesProcessed not report correctly
3 participants