Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Pipeline topics when writable pipeline changed #1198

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Oct 24, 2022

fixes #1187

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run non-secure EdgeX stack
Build ASC with SDK from this PR
Run ASC with profile sample and -cp option
Verify Float pipeline is executed when topic matches
Change topic for Float pipeline from Consul to something that will never match
Verify Float pipeline is never executed when topic would have matched previously

New Dependency Instructions (If applicable)

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member Author

recheck

@codecov-commenter
Copy link

Codecov Report

Merging #1198 (9078b7e) into main (33f1d54) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   66.67%   66.46%   -0.21%     
==========================================
  Files          38       38              
  Lines        3199     3209      +10     
==========================================
  Hits         2133     2133              
- Misses        931      941      +10     
  Partials      135      135              
Impacted Files Coverage Δ
internal/app/configupdates.go 16.86% <0.00%> (-0.21%) ⬇️
internal/runtime/runtime.go 77.25% <0.00%> (-2.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit bf1cebf into edgexfoundry:main Oct 25, 2022
@lenny-goodell lenny-goodell deleted the fix-pipeline-topics branch October 25, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated value of perTopicPipeline didn't enabled before restarting service
3 participants