Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-45087-fix-ebenefit-definition #20817

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+13 −8
Open

API-45087-fix-ebenefit-definition #20817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11061ff
Corrects definition. Adds caching to dep claimant poa assignment. Rep…
stiehlrod Feb 17, 2025
e853ca4
Merge branch 'master' into API-45087-fix-ebenefit-definition
stiehlrod Feb 18, 2025
fdcc6c9
Resolves merge conflict.
stiehlrod Feb 20, 2025
f336332
Merge branch 'master' into API-45087-fix-ebenefit-definition
stiehlrod Feb 20, 2025
c683a2b
Merge branch 'master' into API-45087-fix-ebenefit-definition
stiehlrod Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ module CorporateUpdateWebService
##
# EBenefitsBnftClaimStatusWebServiceBean
#
module EBenefitsBenefitClaimStatusWebServiceBean
module EbenefitsBnftClaimStatusWebServiceBean
DEFINITION =
Bean.new(
path: 'EBenefitsBnftClaimStatusWebServiceBean',
Expand All @@ -200,11 +200,11 @@ module EBenefitsBenefitClaimStatusWebServiceBean
)
end

module EBenefitsBenefitClaimStatusWebService
module EbenefitsBnftClaimStatusWebService
DEFINITION =
Service.new(
bean: EBenefitsBenefitClaimStatusWebServiceBean::DEFINITION,
path: 'EBenefitsBnftClaimStatusWebService'
bean: EbenefitsBnftClaimStatusWebServiceBean::DEFINITION,
path: 'EbenefitsBnftClaimStatusWebService'
)
end

Expand Down
9 changes: 7 additions & 2 deletions modules/claims_api/app/services/claims_api/dependent_claimant_poa_assignment_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ def assign_poa_to_dependent_via_update_benefit_claim?
end

def dependent_claims
res = bgs_claim_status_service.find_benefit_claims_status_by_ptcpnt_id(@dependent_participant_id)
@bgs_claim_status_service ||= ClaimsApi::EbenefitsBnftClaimStatusWebService.new(
external_uid: @dependent_participant_id,
external_key: @dependent_participant_id
)
res = @bgs_claim_status_service.find_benefit_claims_status_by_ptcpnt_id(@dependent_participant_id)

benefit_claims = Array.wrap(res&.dig(:benefit_claims_dto, :benefit_claim))

return benefit_claims if benefit_claims.present? && benefit_claims.is_a?(Array) && benefit_claims.first.present?
Expand All @@ -137,7 +142,7 @@ def dependent_claims
end

def bgs_claim_status_service
ClaimsApi::EbenefitsBnftClaimStatusWebService.new(
@bgs_claim_status_service ||= ClaimsApi::EbenefitsBnftClaimStatusWebService.new(
external_uid: @dependent_participant_id,
external_key: @dependent_participant_id
)
Expand Down
4 changes: 2 additions & 2 deletions modules/claims_api/lib/bgs_service/e_benefits_bnft_claim_status_web_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def find_benefit_claims_status_by_ptcpnt_id(id)
<ptcpntId>#{id}</ptcpntId>
EOXML

make_request(endpoint: 'EBenefitsBnftClaimStatusWebServiceBean/EBenefitsBnftClaimStatusWebService',
make_request(endpoint: bean_name,
action: 'findBenefitClaimsStatusByPtcpntId', body:)
end

Expand All @@ -20,7 +20,7 @@ def find_benefit_claim_details_by_benefit_claim_id(id)
<bnftClaimId>#{id}</bnftClaimId>
EOXML

make_request(endpoint: 'EBenefitsBnftClaimStatusWebServiceBean/EBenefitsBnftClaimStatusWebService',
make_request(endpoint: bean_name,
action: 'findBenefitClaimDetailsByBnftClaimId', body:)
end

Expand Down
Loading