Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-45087-fix-ebenefit-definition #20817

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Corrects definition.
  • Adds caching to dep claimant poa assignment.
  • Replaces hard coded bean and service in ebenefitsbnftclaimstatusweb service.

Related issue(s)

Testing done

  • v1 poa 2122 submit
  • v2 poa submit
  • v1 claims index
  • v2 claims index

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/app/services/claims_api/dependent_claimant_poa_assignment_service.rb
modified:   modules/claims_api/lib/bgs_service/e_benefits_bnft_claim_status_web_service.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…laces hard coded bean and service in ebenefitsbnftclaimstatusweb service.
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and received responses as expected, no errors in terminal. Looks good!

@stiehlrod stiehlrod marked this pull request as draft February 20, 2025 18:38
@stiehlrod stiehlrod marked this pull request as ready for review February 20, 2025 18:39
@va-vfs-bot va-vfs-bot temporarily deployed to API-45087-fix-ebenefit-definition/main/main February 20, 2025 18:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-45087-fix-ebenefit-definition/main/main February 20, 2025 18:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants