Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle case where claimant response isn't a hash #20125

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Changes from 6 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4399675
handle case where claimant response isn't a hash
s-caso Jan 7, 2025
46a2bf2
update syntax for string check
s-caso Jan 7, 2025
1dbfbb0
use respond to to check if fetch is viable
s-caso Jan 7, 2025
c758406
lint fix
s-caso Jan 7, 2025
1c1be9d
Merge branch 'master' into claimant-response-issue
s-caso Jan 8, 2025
89bd804
Merge branch 'master' into claimant-response-issue
s-caso Jan 28, 2025
6955dd6
added specs for claimant service response
s-caso Feb 4, 2025
be6a018
Merge branch 'claimant-response-issue' of github.com:department-of-ve…
s-caso Feb 4, 2025
99fb7b0
lint fixes
s-caso Feb 4, 2025
1089531
lint fix
s-caso Feb 4, 2025
8db91ab
Merge branch 'master' into claimant-response-issue
s-caso Feb 4, 2025
33275b2
retry claimant id call to avoid race condition
s-caso Feb 19, 2025
c00d73c
Merge branch 'master' into claimant-response-issue
s-caso Feb 19, 2025
9d25224
lint fixes
s-caso Feb 19, 2025
9445565
Merge branch 'claimant-response-issue' of github.com:department-of-ve…
s-caso Feb 19, 2025
c58927a
Merge branch 'master' into claimant-response-issue
s-caso Feb 19, 2025
64689ed
remove useless rescue
s-caso Feb 19, 2025
77a94ef
Merge branch 'claimant-response-issue' of github.com:department-of-ve…
s-caso Feb 19, 2025
71c72e0
Merge branch 'master' into claimant-response-issue
s-caso Feb 19, 2025
0fcdaf6
Merge branch 'master' into claimant-response-issue
s-caso Feb 19, 2025
cc0ce2d
Merge branch 'master' into claimant-response-issue
s-caso Feb 20, 2025
5c0b141
revert to old code as retry will handle nil case
s-caso Feb 20, 2025
5ebfa05
Merge branch 'claimant-response-issue' of github.com:department-of-ve…
s-caso Feb 20, 2025
be7d700
refactor claim status endpoint and add spec
s-caso Feb 20, 2025
f9061e9
add spec
s-caso Feb 20, 2025
aabf01a
lint fixes
s-caso Feb 20, 2025
e6e8eb9
lint fixes
s-caso Feb 20, 2025
f4d40dc
Merge branch 'master' into claimant-response-issue
s-caso Feb 20, 2025
93e6209
Merge branch 'master' into claimant-response-issue
s-caso Feb 21, 2025
e80a584
Merge branch 'master' into claimant-response-issue
s-caso Feb 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/meb_api/lib/dgi/claimant/claimant_response.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class ClaimantResponse < MebApi::DGI::Response

def initialize(status, response = nil)
attributes = {
claimant_id: response&.body&.fetch('claimant_id', nil)
claimant_id: response&.body.respond_to?(:fetch) ? response&.body&.fetch('claimant_id', nil) : response&.body
}
super(status, attributes)
end
Expand Down
Loading