Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case where claimant response isn't a hash #20125

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

handle case where claimant response isn't a hash #20125

wants to merge 30 commits into from
+292 −6

Conversation

s-caso
Copy link
Contributor

@s-caso s-caso commented Jan 7, 2025 •
edited
Loading

Summary

  • Check if response body responds to fetch call other wise just return body

Screenshots

Screenshot 2024-12-23 at 9 36 26 AM (1)

@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main January 7, 2025 18:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main January 7, 2025 18:23 Inactive
@s-caso s-caso marked this pull request as ready for review January 7, 2025 20:48
@s-caso s-caso requested a review from a team as a code owner January 7, 2025 20:48
bradbergeron-us
bradbergeron-us previously approved these changes Jan 7, 2025
View reviewed changes
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main January 7, 2025 21:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main January 8, 2025 16:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main January 29, 2025 00:54 Inactive
@bradbergeron-us bradbergeron-us self-requested a review February 20, 2025 15:19
stevenjcumming
stevenjcumming requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@stevenjcumming stevenjcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retries like this must be performed in a background job. It can't be part of the request/response cycle.

@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 20, 2025 20:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 20, 2025 21:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 20, 2025 21:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 20, 2025 22:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 20, 2025 22:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to claimant-response-issue/main/main February 21, 2025 13:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjcumming stevenjcumming stevenjcumming requested changes

@bradbergeron-us bradbergeron-us bradbergeron-us left review comments

@rmtolmach rmtolmach Awaiting requested review from rmtolmach

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ready-for-backend-review require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-caso @bradbergeron-us @rmtolmach @stevenjcumming @va-vfs-bot