Release v13.12.0 #1875
Merged
Release v13.12.0 #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cover remaining utilities in EDS _utils
fix: replace named lodash imports with deep ones for better tree shaking
Instead of
import { debounce } from 'lodash';
use
import debounce from 'lodash/debounce';
This helps with tree shaking. In particular I ran into issues with this
when trying to update Remix apps to use Vite.
An alternative would be to use 'lodash-es' instead, which is esm modules.
- model it to work and look like what exists for InputField - add tests and new snapshots - add rule override for disabled components
Co-authored-by: Renovate Bot <[email protected]>
* add max height for Select.Options * update test to snapshot when open * add padding for visibility * remove unnecessary waitFor call
Usages in our Remix apps will not need to deeply import anymore (in fact,
they cannot with Vite due to how the bundling works)
- import type {ClickableStyleProps} from "@chanzuckerberg/eds/lib/components/ClickableStyle";
+ import type {ClickableStyleProps} from "@chanzuckerberg/eds";
We need the ClickableStyleProps for our custom Remix Link component, so
we properly integrate the Remix and EDS Link components.
Re-exporting the props is easier to work with. The deep import in edu-stack was always a hack.
* chore: test commit lint change (1/n) * chore: test spaces (2/n) * chore: test github.event.distinct_size (3/n) * chore: test the original command's meaning (4/n) * chore: filter on just commit IDs for counting (5/n) * chore: tidy up pull request template (6/n) * chore: document where the filtering technique comes from (7/n)
Co-authored-by: Renovate Bot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
+ Coverage 91.31% 92.62% +1.31%
==========================================
Files 148 148
Lines 2855 2862 +7
Branches 776 780 +4
==========================================
+ Hits 2607 2651 +44
+ Misses 221 195 -26
+ Partials 27 16 -11 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
ahuth
approved these changes
Mar 4, 2024
|
Thanks @ahuth ! doing this last small PR for the lingering v13 stuff, then will finish up work on v14 later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
13.12.0 (2024-03-04)
Storybook
Features
Bug Fixes