fix(Select): add max height for Select.Options #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1858 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 148 148
Lines 2862 2862
Branches 780 780
=======================================
Hits 2650 2650
Misses 195 195
Partials 17 17 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
ahuth
reviewed
Feb 26, 2024
ahuth
reviewed
Feb 26, 2024
booc0mtaco
force-pushed
the
aholloway/EFI-1615
branch
from
bec1fe0 to
e5bf679
Compare
booc0mtaco
force-pushed
the
aholloway/EFI-1615
branch
from
e5bf679 to
a1925a9
Compare
Screen.Recording.2024-02-26.at.13.47.59.mov |
|
@ahuth thanks 🙏 |
Merged
booc0mtaco
added a commit
that referenced
this pull request
Mar 4, 2024
## [13.12.0](v13.11.0...v13.12.0) (2024-03-04) [Storybook](https://61313967cde49b003ae2a860-telsscxlak.chromatic.com/?path=/docs/getting-started--docs) ### Features * export ClickableStyleProps ([#1860](#1860)) ([0d1b49e](0d1b49e)) * **Select:** add support for required in overline ([#1855](#1855)) ([6e44566](6e44566)) ### Bug Fixes * lodash tree shaking ([#1852](#1852)) ([f55f9cb](f55f9cb)) * **Select:** add max height for Select.Options ([#1858](#1858)) ([24ed8bc](24ed8bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
before, it was possible for options to extend beyond the full height of the page, or be taller than the page. Make it so that its height is capped at a maximum of 25% screen state. Add tests to show the keyboard nav works properly
Test Plan: