Skip to content

Commit

Permalink
Merge pull request #64 from brunomikoski/feature/ui-manager-implement…
Browse files Browse the repository at this point in the history
…ation

Refactor and Improvements
  • Loading branch information
brunomikoski authored Mar 30, 2021
2 parents 43c0d5c + 9ba9334 commit 084bf5f
Show file tree
Hide file tree
Showing 70 changed files with 1,808 additions and 1,520 deletions.
17 changes: 17 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,22 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.5.0]
### Changed
- Refactored the `Collectable` for `CollectionItem` this has several changes in multiple parts of the code, I tried my best to keep compability with the old version as well.
- Renamed the `CollectableScriptableObject` to `ScriptableObjectCollectionItem` for better naming convention, `CollectableScriptableObject` still exist but has the obsolete flag on it to avoid breakable changes
- Add `IsValid` to IndirectReferences to check if has valid data before being used
- Refactored `ResourceScriptableObjectSingleton` to fix some warnings
- Fixed the `GetEnumerator` from `Collection` warning
- The `CollectionRegistry` now will only load Collections that are inside an active Assembly.
- Exposed the `Collections` list on the Registry
- Simplified the CollectionItem Dropdown (removed the type grouping)

### Added
- A new information on the Collection custom editor to show the base class if is different from the collection type (Disabled for now)
- Exposed the namespace to be customized by the custom static file
- Added support of multiple collections of the same type on the registry, the `CollectionItemDrawer` will display a Collection dropdown if more than one collection for the same type of item is available

## [1.4.1]
### Changed
- Fixed issue when using the Create Settings menu
Expand Down Expand Up @@ -193,6 +209,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### [Unreleased]



[1.4.1]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.4.1
[1.4.0]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.4.0
[1.3.2]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.3.2
Expand Down
83 changes: 0 additions & 83 deletions Scripts/Editor/CollectableDropdown.cs

This file was deleted.

14 changes: 0 additions & 14 deletions Scripts/Editor/CollectableDropdownItem.cs

This file was deleted.

228 changes: 0 additions & 228 deletions Scripts/Editor/CollectableScriptableObjectPropertyDrawer.cs

This file was deleted.

8 changes: 8 additions & 0 deletions Scripts/Editor/Core.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ public static AssetDeleteResult OnWillDeleteAsset(string targetAssetPath, Remove

Type type = mainAssetAtPath.GetType();

if (type.IsSubclassOf(typeof(CollectableScriptableObject)))
if (type.IsSubclassOf(typeof(ScriptableObjectCollectionItem)))
{
CollectableScriptableObject collectable =
AssetDatabase.LoadAssetAtPath<CollectableScriptableObject>(targetAssetPath);
ScriptableObjectCollectionItem collectionItem =
AssetDatabase.LoadAssetAtPath<ScriptableObjectCollectionItem>(targetAssetPath);

collectable.Collection.Remove(collectable);
collectionItem.Collection.Remove(collectionItem);
return AssetDeleteResult.DidNotDelete;
}

Expand All @@ -35,4 +35,4 @@ public static AssetDeleteResult OnWillDeleteAsset(string targetAssetPath, Remove
}

}
}
}
Loading

0 comments on commit 084bf5f

Please sign in to comment.