Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Improvements #64

Merged
merged 19 commits into from
Mar 30, 2021
Merged

Conversation

brunomikoski
Copy link
Owner

@brunomikoski brunomikoski commented Mar 30, 2021

Changed

  • Renamed the Collectable for CollectionItem this has several changes in multiple parts of the code, I tried my best to keep compatibility with the old version. CollectableScriptableObject still exists but has the obsolete flag on it to avoid breakable changes.
  • Add IsValid to IndirectReferences to check if has valid data before being used
  • Refactored ResourceScriptableObjectSingleton to fix some warnings
  • Fixed the GetEnumerator from Collection warning
  • The CollectionRegistry now will only load Collections that are inside an active Assembly.
  • Exposed the Collections list on the Registry
  • Simplified the CollectionItem Dropdown (removed the type grouping)
  • Multiple QoL improvements on the codebase.

Added

  • A new information on the Collection custom editor to show the base class if is different from the collection type (Disabled for now)
  • Exposed the namespace to be customized by the custom static file
  • Added support of multiple collections of the same type on the registry, the CollectionItemDrawer will display a Collection dropdown if more than one collection for the same type of item is available

Fixed: #63
Fixed: #61
Fixed: #60
Fixed: #59
Implemented: #51

@brunomikoski brunomikoski merged commit 084bf5f into master Mar 30, 2021
@brunomikoski brunomikoski deleted the feature/ui-manager-implementation branch March 30, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant