fix(helm): syntax fix in dashboard template #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippitt
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
pippitt
force-pushed
the
fix/configmap_dashboard_helm
branch
2 times, most recently
from
abde7a7 to
9fc2a30
Compare
Signed-off-by: Matt Pippitt <[email protected]>
pippitt
force-pushed
the
fix/configmap_dashboard_helm
branch
from
9fc2a30 to
c1f8b79
Compare
alvneiayu
approved these changes
Dec 23, 2023
Merged
alvneiayu
added a commit
that referenced
this pull request
Dec 23, 2023
Release chart 2.14.1 Includes: * Syntax fix in dashboard template #1417 Fixes #1416 Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Addresses #1416
Update dashboard configmap template syntax on commonLabels
Benefits
When dashboards are enabled helm will now render them correctly.
Possible drawbacks
None know.
Applicable issues
Additional information
Tested with helm template. Before fix with dashboards enabled:
With change, renders as expected.