Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart 2.14.0 error if dashboard enabled after commonLabels added #1416

Closed
pippitt opened this issue Dec 22, 2023 · 0 comments · Fixed by #1417 or #1418
Closed

Helm chart 2.14.0 error if dashboard enabled after commonLabels added #1416

pippitt opened this issue Dec 22, 2023 · 0 comments · Fixed by #1417 or #1418
Labels
triage Issues/PRs that need to be reviewed

Comments

@pippitt
Copy link
Contributor

pippitt commented Dec 22, 2023

Which component:
controller helm chart

Describe the bug
Withmetrics.dashboards.create: true
helm generates an error

$ helm template testing . --values ./dashboard.values.yaml
Error: template: sealed-secrets/templates/configmap-dashboards.yaml:14:18: executing "sealed-secrets/templates/configmap-dashboards.yaml" at <.Values.commonLabels>: can't evaluate field Values in type []uint8

Use --debug flag to render out invalid YAML

To Reproduce
Steps to reproduce the behavior:

  1. Set metrics.dashboards.create: true in values.yaml being used
  2. Run helm command
  3. See error listed above

Expected behavior
Helm produces objects without error.

Version of Kubernetes:
NA

I believe I have the fix, and will make a PR.
@pippitt pippitt added the triage Issues/PRs that need to be reviewed label Dec 22, 2023
@pippitt pippitt mentioned this issue Dec 22, 2023
Merged
alvneiayu pushed a commit that referenced this issue Dec 23, 2023
@pippitt
fix(helm): syntax fix in dashboard template (#1417)
c418d12 
**Description of the change**

Addresses #1416
Update dashboard configmap template syntax on commonLabels

**Benefits**

When dashboards are enabled helm will now render them correctly.

**Possible drawbacks**

None know.

**Applicable issues**

<!-- Enter any applicable Issues here (You can reference an issue using
#) -->
- fixes #1416

**Additional information**

Tested with helm template.  Before fix with dashboards enabled:
```
helm template testing . --values values.yaml
Error: template: sealed-secrets/templates/configmap-dashboards.yaml:14:18: executing "sealed-secrets/templates/configmap-dashboards.yaml" at <.Values.commonLabels>: can't evaluate field Values in type []uint8

Use --debug flag to render out invalid YAML
```
With change, renders as expected.

Signed-off-by: Matt Pippitt <[email protected]>
@alvneiayu alvneiayu mentioned this issue Dec 23, 2023
Merged
alvneiayu added a commit that referenced this issue Dec 23, 2023
@alvneiayu
Release chart 2.14.1 (#1418)
e0fd286 
Release chart 2.14.1

Includes: 
* Syntax fix in dashboard template #1417

Fixes #1416

Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issues/PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
1 participant
@pippitt