Fix windows paths #52
Conversation
| @@ -82,7 +83,7 @@ module.exports = function(source) { | |||
| cell : bemCell, | |||
| exist, | |||
| // prepare path for require cause relative returns us string that we couldn't require | |||
| path : requiredPath(path.relative(path.dirname(this.resourcePath), entityPath)) | |||
| path : winPath(requiredPath(path.relative(path.dirname(this.resourcePath), entityPath))) | |||
There was a problem hiding this comment.
Feels like It's a requiredPath trouble, I told you path for require should be with slash (not a backslash) even on windows.
There was a problem hiding this comment.
no, it's not a problem with requiredPath, I checked
Take a look at #51
there are no slashes here ./common.blocksAppRouterAppRouter.js
it should be ./common.blocks\AppRouter\AppRouter.js there is nothing wrong with requiredPath . It's problem elsewhere
There was a problem hiding this comment.
Moreover, these guys don't use required-path but unify path too. why?
https://github.com/ant-design/babel-plugin-import/blob/master/src/Plugin.js#L14
There was a problem hiding this comment.
@zxqfox
I described all solutions in detals at #26 (comment)
So seems @Yeti-or decided to go with make replace on output of required-path call
There was a problem hiding this comment.
Moreover, these guys don't use required-path but unify path too. why?
Because they are decided to stick to / instead of escaping \ characters.
The problem is path writing to file where it will be evaluated from './App\App.js' to './AppApp.js' as @Guria described in their comment.
These guys also has a special option customName that can return undetermined result (we can't sure the result won't have \ character) so they just replaces all \ with / that they don't need to escape.
So it's viable solution. But if we'll get some troubles with that in future we should keep that problem in mind.
I'd say we should left a comment in code to this thread at least.
Yeti-or
force-pushed
the
yeti-or.win-path
branch
from
6298e52 to
fa218b1
Compare
closes #51