Fix windows separators in pathStr #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm. This will fix an issue but seems problem is not in require and/or webpack. investigating. |
Guria
commented
Aug 16, 2017
| @@ -1,6 +1,7 @@ | |||
| var path = require('path'); | |||
| var assert = require('assert'); | |||
|
|
|||
| // path.sep shouldn't be used since require doesn't support windows separator | |||
There was a problem hiding this comment.
comment statement isn't true.
see bem/webpack-bem-loader#26 (comment)
|
@Yeti-or How about a |
|
I will check it at tonight, thanx
…On Wed, 16 Aug 2017 at 13:42, Aleksey Guryanov ***@***.***> wrote:
@Yeti-or <https://github.com/yeti-or> How about a keepSeparator flag? Do
not replace anything and use path.sep when making relative if flag is set
to true or replace any windows separators with nix ones otherwise?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABur3NKr6Ay5IaqppZ0ZYdwEmAt-7132ks5sYsesgaJpZM4O4p0i>
.
|
|
@Yeti-or Did you come up with smth? |
|
@Yeti-or ping! |
|
would be great to hear smth here so we would be able to move on |
|
We fixed it inside |
|
@Guria check bem/webpack-bem-loader#52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up from bem/webpack-bem-loader#26