Hook up linker to nodejs_binary/nodejs_test #1430
Conversation
alexeagle
force-pushed
the
link_all_the_things
branch
5 times, most recently
from
98bb420 to
861d445
Compare
alexeagle
force-pushed
the
link_all_the_things
branch
2 times, most recently
from
57b5cc1 to
b697944
Compare
examples/jest/package.json
Outdated
| @@ -18,6 +18,6 @@ | |||
| }, | |||
| "scripts": { | |||
| "test": "bazel test ...", | |||
| "postinstall": "patch-package --patch-dir=./tools/patches" | |||
| "// postinstall": "patch-package --patch-dir=./tools/patches" | |||
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
gregmagolan
force-pushed
the
link_all_the_things
branch
2 times, most recently
from
7ba210a to
96e99e1
Compare
|
@alexeagle Looks like the only failing test was already failing in prior builds: https://buildkite.com/bazel/rules-nodejs-nodejs/builds/5046 It also passes on my personal mac :) |
|
Ahh. Thanks for pointing that out. It's a strange heisenbug that shows up only on bazelci osx. I haven't been able to reproduce it locally either. |
|
@gregmagolan The package the error references is And if that doesn't work just pray to your chosen deity and ask for forgiveness |
This makes it easier to reuse in nodejs_binary
- nodejs_binary and nodejs_test will always produce a modules manifest needed by the linker - if the program isn't run with a user-specific linker manifest, we use the static one as a default - always pass the flag to opt-out of custom module resolver for generated rules Fixes bazel-contrib#1382
alexeagle
force-pushed
the
link_all_the_things
branch
from
96e99e1 to
58b66f4
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
For #1382
Pairing with @mrmeku on it today