Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bazel integration #16370

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fix bazel integration #16370

merged 2 commits into from
Dec 9, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 6, 2019 •
edited
Loading

//cc @alexeagle

@alan-agius4
fix(@angular-devkit/build-angular): add symlinks option to resolveLoader
1be826d 
This is needed as otherwise under Bazel it will fail with `Angular Compiler was detected but it was an instance of the wrong class.` when not using the linker since node_modules will be linked to `external/npm`. Under Bazel `preserveSymlinks` is to be set to true, however with the current behaviour this doesn't effect resolveLoader.
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 6, 2019
@alan-agius4 alan-agius4 requested a review from clydin December 6, 2019 10:00
@alan-agius4
fix(@angular-devkit/build-angular): resolve @babel/preset-env
102111f 
This is needed as otherwise under Bazel we hit `Cannot find module '@babel/preset-env` we use `require.resolve` since this is always patched under Bazel.
@alexeagle
Copy link
Contributor

I think this PR should no longer be necessary once bazel-contrib/rules_nodejs#1430 lands
It will cause us to lay out the normal node_modules tree in the working directory and patch the symlink primitives in node, when you call architect via a load from index.bzl

@mrmeku
Copy link
Contributor

mrmeku commented Dec 9, 2019

@alexeagle That might not necessarily be the case until we change the generated nodejs_test target to have its entry point live from within the normal node_modules directory. As it is the entry point will still be external/npm after that PR lands.

@kyliau kyliau merged commit f1985e1 into angular:master Dec 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2020
@alan-agius4 alan-agius4 deleted the fix-bazel-integration branch January 9, 2020 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alan-agius4 @alexeagle @mrmeku @clydin @kyliau @googlebot