This repository has been archived by the owner on Feb 9, 2020. It is now read-only.
feat(ElementPanel): display scope properties for children of DocumentFragments #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fragments Sort of related to angular/angular.js#6637 --- Currently, jqLite#inheritedData() will not find data if it needs to cross through document fragment barriers, such as the Shadow DOM barrier. This patch allows batarang to figure this out. In addition, it provides some tests for the angularjs properties sidebar of the element panel, which were missing previously. Closes angular#104
|
It would probably be good to fix the tests so that they can run in a modern karma, or else add a karma task to the grunt file, so that there's some evidence that stuff works at all. This CL doesn't break any tests, however there turns out to be two failing specs in the tree already :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of related to angular/angular.js#6637 ---
Currently, jqLite#inheritedData() will not find data if it needs to cross
through document fragment barriers, such as the Shadow DOM barrier. This patch
allows batarang to figure this out.
In addition, it provides some tests for the angularjs properties sidebar of
the element panel, which were missing previously.
Closes #104