This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): traverse host property for DocumentFragment in inheritedData()
#6637
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somewhat related to this, batarang doesn't seem interested in piercing shadow barriers either, it would be good to fix that |
| // to lookup parent controllers. | ||
| var parent = element.parent(); | ||
| if (!parent.length) { | ||
| if (element[0].parentNode) parent = jqLite(element[0].parentNode); |
There was a problem hiding this comment.
can you expand this to
if (condition) {
fooo
} if else (condition2) {
baaar
}
There was a problem hiding this comment.
should we keep local reference to element[0] instead of uwrapping it 4 times in this code?
…edData() If dealing with a document fragment node with a host element, and no parent, use the host element as the parent. This enables directives within a Shadow DOM or polyfilled Shadow DOM to lookup parent controllers.
caitp
added a commit
to caitp/angularjs-batarang
that referenced
this pull request
Mar 15, 2014
…Fragments Sort of related to angular/angular.js#6637 --- Currently, jqLite#inheritedData() will not find data if it needs to cross through document fragment barriers, such as the Shadow DOM barrier. This patch allows batarang to figure this out. In addition, it provides some tests for the angularjs properties sidebar of the element panel, which were missing previously. Closes angular#104
|
I think I got a "merge it" in the meeting, so, I'm gonna check this in. It's unlikely to break anything, at any rate |
caitp
added a commit
that referenced
this pull request
Mar 21, 2014
…edData() If dealing with a document fragment node with a host element, and no parent, use the host element as the parent. This enables directives within a Shadow DOM or polyfilled Shadow DOM to lookup parent controllers. Closes #6637
caitp
added a commit
to angular/batarang
that referenced
this pull request
Jul 16, 2015
…Fragments Sort of related to angular/angular.js#6637 --- Currently, jqLite#inheritedData() will not find data if it needs to cross through document fragment barriers, such as the Shadow DOM barrier. This patch allows batarang to figure this out. In addition, it provides some tests for the angularjs properties sidebar of the element panel, which were missing previously. Closes #104
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dealing with a document fragment node with a host element, and no parent, use the host element as the parent. This enables directives within a Shadow DOM or polyfilled Shadow DOM to lookup parent controllers.
This is something which would be well-suited for 1.2.x as well as a 1.3 beta, in my opinion, as use of the shadowDOM may become more commonplace. This solution works for both the Polymer polyfill as well as the native implementation in Canary
(might technically be a feature, but it feels like "fixing things to work with modern web", really)