Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow creation of multiple client instances based on api key #38

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: Allow creation of multiple client instances based on api key #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c98ea6d
fix: Allow creation of multiple experiment client instances based on …
Sep 1, 2023
aacc0f0
comment and description update
Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/amplitude_experiment/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

remote_evaluation_instances = {}
local_evaluation_instances = {}
default_instance = '$default_instance'


class Experiment:
Expand All @@ -23,9 +22,9 @@ def initialize_remote(api_key: str, config: RemoteEvaluationConfig = None) -> Re
Returns:
The remote evaluation client.
"""
if remote_evaluation_instances.get(default_instance) is None:
remote_evaluation_instances[default_instance] = RemoteEvaluationClient(api_key, config)
return remote_evaluation_instances[default_instance]
if remote_evaluation_instances.get(api_key) is None:
remote_evaluation_instances[api_key] = RemoteEvaluationClient(api_key, config)
return remote_evaluation_instances[api_key]

@staticmethod
def initialize_local(api_key: str, config: LocalEvaluationConfig = None) -> LocalEvaluationClient:
Expand All @@ -40,6 +39,6 @@ def initialize_local(api_key: str, config: LocalEvaluationConfig = None) -> Loca
Returns:
The local evaluation client.
"""
if local_evaluation_instances.get(default_instance) is None:
local_evaluation_instances[default_instance] = LocalEvaluationClient(api_key, config)
return local_evaluation_instances[default_instance]
if local_evaluation_instances.get(api_key) is None:
local_evaluation_instances[api_key] = LocalEvaluationClient(api_key, config)
return local_evaluation_instances[api_key]