Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow creation of multiple client instances based on api key #38

Merged
merged 2 commits into from
Sep 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/amplitude_experiment/factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,25 @@

remote_evaluation_instances = {}
local_evaluation_instances = {}
default_instance = '$default_instance'


class Experiment:
"""Provides factory methods for storing singleton instance of Client"""
"""Provides factory methods for storing instances of Client"""

@staticmethod
def initialize_remote(api_key: str, config: RemoteEvaluationConfig = None) -> RemoteEvaluationClient:
"""
Initializes a singleton Client. This method returns a default singleton instance, subsequent calls to
init will return the initial instance regardless of input.
Initializes a remote evaluation client.
Parameters:
api_key (str): The Amplitude API Key
config (RemoteEvaluationConfig): Optional Config

Returns:
The remote evaluation client.
A remote evaluation client.
"""
if remote_evaluation_instances.get(default_instance) is None:
remote_evaluation_instances[default_instance] = RemoteEvaluationClient(api_key, config)
return remote_evaluation_instances[default_instance]
if remote_evaluation_instances.get(api_key) is None:
remote_evaluation_instances[api_key] = RemoteEvaluationClient(api_key, config)
return remote_evaluation_instances[api_key]

@staticmethod
def initialize_local(api_key: str, config: LocalEvaluationConfig = None) -> LocalEvaluationClient:
Expand All @@ -38,8 +36,8 @@ def initialize_local(api_key: str, config: LocalEvaluationConfig = None) -> Loca
config (RemoteEvaluationConfig): Optional Config

Returns:
The local evaluation client.
A local evaluation client.
"""
if local_evaluation_instances.get(default_instance) is None:
local_evaluation_instances[default_instance] = LocalEvaluationClient(api_key, config)
return local_evaluation_instances[default_instance]
if local_evaluation_instances.get(api_key) is None:
local_evaluation_instances[api_key] = LocalEvaluationClient(api_key, config)
return local_evaluation_instances[api_key]