This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry pick filter fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in druid (apache#5162) * added disabled message for custom sql tab on druid datasources * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indent. * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indentation. (cherry picked from commit b53b240)
(cherry picked from commit 5b35f75)
Codecov Report
@@ Coverage Diff @@
## airbnb-master #51 +/- ##
==============================================
Coverage 77.45% 77.45%
==============================================
Files 44 44
Lines 8672 8672
==============================================
Hits 6717 6717
Misses 1955 1955Continue to review full report at Codecov.
|
timifasubaa
approved these changes
Jun 7, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
feat: Add `reactify` function from `incubator-superset`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking fixes to adhoc filters
empty lists are invalid comparators (apache#5160) (cherry picked from commit 5b35f75)
[migration] Adding migration to remove empty in/not-in filters (apache#5161) (cherry picked from commit 1b4406d)
[Explore][Adhoc Metrics/ Filters] disabled message for custom sql tab in druid (apache#5162) (cherry picked from commit b53b240)
@john-bodley @GabeLoins @timifasubaa @graceguo-supercat