[migration] Adding migration to remove empty in/not-in filters #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5161 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 44 44
Lines 8741 8741
=======================================
Hits 6772 6772
Misses 1969 1969Continue to review full report at Codecov.
|
|
lgtm |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 7, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration which removes instances of empty in/not-in filters. Note prior to adhoc-filters we speculate these were ignored whereas now they're present in the query (in the form of
1 != 1).It's unclear how these filters came to exist in this state but it seems prudent to simply remove them as with adhoc filters any slices with these invalid filters will result in no data.
to: @GabeLoins @michellethomas @mistercrunch