Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage and some minor fixes. #467

Merged
merged 78 commits into from
Oct 11, 2022
Merged

Increase coverage and some minor fixes. #467

merged 78 commits into from
Oct 11, 2022

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Sep 16, 2022

Code changes:

AbstractSingleSourcePartition.add_edge do check before changing state

ApplicationGraph
add_edge: do check before changing state:
add_outgoing_edge_partition: now private and all safety checks removed
get_edges_starting_at_vertex: removed as unused

ApplicationFPGAVertex.incoming_fpga_connection now yields nothing rather than raise a weird exception if no connections

ConstrainedObject removed check for None as isinstance fails on None

ConstantSDRAMMachinePartition.get_sdram_size_of_region_for
simplified to use known value

DestinationSegmentedSDRAMMachinePartition.
raise exception rather than return None for don't know

SourceSegmentedSDRAMMachinePartition.
do check before changing state
add_edge
@sdram_base_address.setter

SplitterExternalDevice.set_governed_app_vertex
Removed if as always True on a generator

SplitterOneToOneLegacy.set_governed_app_vertex
do check before changing state

MultiRegionSDRAM.nest bug fix for other types

ReverseIPtagResource eq: bug fix for other types

merged_routing_table_generator
- next as a property fails if using a debugger as debugger removes elements.
replaced next with pop method
made peek a method for consitency

  • removed unused create_entry method

RoutingTree
removed a setter
fixed type in docs

Added lots of unittests

Some of the code not tested will be remove in or with
#460
#465
#464

tested by:
SpiNNakerManchester/IntegrationTests#141
(note other prs tested there can be merged individually)

Copy link
Member

@dkfellows dkfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions. Other stuff looks fine.

@Christian-B Christian-B merged commit 7261286 into master Oct 11, 2022
@Christian-B Christian-B deleted the coverage branch October 11, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants