-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase coverage and some minor fixes. #467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkfellows
reviewed
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions. Other stuff looks fine.
pacman/model/graphs/machine/destination_segmented_sdram_machine_partition.py
Show resolved
Hide resolved
pacman/operations/routing_table_generators/merged_routing_table_generator.py
Show resolved
Hide resolved
dkfellows
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes:
AbstractSingleSourcePartition.add_edge do check before changing state
ApplicationGraph
add_edge: do check before changing state:
add_outgoing_edge_partition: now private and all safety checks removed
get_edges_starting_at_vertex: removed as unused
ApplicationFPGAVertex.incoming_fpga_connection now yields nothing rather than raise a weird exception if no connections
ConstrainedObject removed check for None as isinstance fails on None
ConstantSDRAMMachinePartition.get_sdram_size_of_region_for
simplified to use known value
DestinationSegmentedSDRAMMachinePartition.
raise exception rather than return None for don't know
SourceSegmentedSDRAMMachinePartition.
do check before changing state
add_edge
@sdram_base_address.setter
SplitterExternalDevice.set_governed_app_vertex
Removed if as always True on a generator
SplitterOneToOneLegacy.set_governed_app_vertex
do check before changing state
MultiRegionSDRAM.nest bug fix for other types
ReverseIPtagResource eq: bug fix for other types
merged_routing_table_generator
- next as a property fails if using a debugger as debugger removes elements.
replaced next with pop method
made peek a method for consitency
RoutingTree
removed a setter
fixed type in docs
Added lots of unittests
Some of the code not tested will be remove in or with
#460
#465
#464
tested by:
SpiNNakerManchester/IntegrationTests#141
(note other prs tested there can be merged individually)