Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proxy and client cert authentication #1068

Merged
merged 10 commits into from
Mar 5, 2021
Merged

fix: Proxy and client cert authentication #1068

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
564efa6
first version linter
FrankEssenberger Mar 3, 2021
bf389c6
update changelog
FrankEssenberger Mar 3, 2021
0b66564
add a bit more logs.
FrankEssenberger Mar 4, 2021
b59c995
add a bit more logs.
FrankEssenberger Mar 4, 2021
5c5fe38
remarks junjie
FrankEssenberger Mar 5, 2021
c147edd
empty spaces
FrankEssenberger Mar 5, 2021
2981b67
linter also no shadow tested and it stays.
FrankEssenberger Mar 5, 2021
f451ca5
Update packages/core/src/connectivity/scp-cf/proxy-util.ts
FrankEssenberger Mar 5, 2021
686bd21
linter fix tests 1
FrankEssenberger Mar 5, 2021
474f2d4
fix more tests linter
FrankEssenberger Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
empty spaces
  • Loading branch information
@FrankEssenberger
FrankEssenberger committed Mar 5, 2021
commit c147edd945d57a81403802115a465f757689f6f5
4 changes: 2 additions & 2 deletions packages/core/src/http-client/http-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export function getAgentConfig(
// eslint-disable-next-line @typescript-eslint/no-shadow
const certificateOptions = getCertificateOption(destination);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see shadow name. Could you please share a bit details?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me I got a lint error that the variable in the if block below is shadowed - I do not understand that either.

if (agentType === AgentType.PROXY) {
return createProxyAgent(destination,certificateOptions);
return createProxyAgent(destination, certificateOptions);
}
return createDefaultAgent(destination,certificateOptions);
return createDefaultAgent(destination, certificateOptions);
}

enum AgentType {
Expand Down